Development after Release of v0.4.1

[nickvergessen]

Any notes or discussions?

[nickvergessen]

One note:
I won't do anything functional to 0.4.2
v0.4.2 will jsut be a code clean up:

• deleting some unused language-strings
• retabbing some parts correctly
• comment the functions
• structure some code logically

I hope you don't mind this development break, it's just to improve translations, addon-development and the development itself.

[grotevoet]

Keep the smooth updating in place - 5 minutes was all it took to move from 0.4.0 to 0.4.1 ...

When looking at Smartor's version, I think you miss only the FAQ extension.
Maybe you can add some more comments in the ACP (to improve explaining what each field does), or maybe an Admin guide (should include some of the FAQs posted in this forum).

I think that if you closed the remaining bugs you should be ready for a 1.0.0 !

Regards,
Marc

[nickvergessen]

I think that if you closed the remaining bugs you should be ready for a 1.0.0 !

There are no remaining bugs, but only feature requests

[zkaraca]

Just a question; Are the rates and views used for some kind of display? Highest rated, most viewed etc like in the (abandoned) TS Gallery Mod? If not, is this going to be developed? I really liked the idea of a tabbed menu with links to the hot pics, most viewed, recent added etc.

[nickvergessen]

It's not planned for the normal version, but maybe Someone develops a nice addon out of it?

[nickvergessen]

Btw

the first step of my cleanup was made.
I ordered all the language-variables alphabetically:

[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/exif_data.php?rev=849&rev_to=825[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/gallery.php?rev=850&rev_to=818[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/gallery_acp.php?rev=850&rev_to=826[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/gallery_mcp.php?rev=847&rev_to=726[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/gallery_ucp.php?rev=849&rev_to=647[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/info_acp_gallery.php?rev=849&rev_to=633[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/info_ucp_gallery.php?rev=849&rev_to=633[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/install_gallery.php?rev=847&rev_to=763[/svn-file]
[svn-file]http://code.bantux.org/repositories/diff/phpbb-gallery/trunk/root/language/en/mods/permissions_gallery.php?rev=847&rev_to=780[/svn-file]

[zkaraca]

So the rate of a picture is just shown when you see the picture? What is the use of that i don't understand? Because i think this will become useless with large albums and many pics. A nice pic which has been rated 500 times with a high rate just gets lost. I hope you get my point.

Well, i'll install this gallery soon and hope someone develops such an addon. I would like to thank you for this great mod Nice work. Like all of your mods by the way.

[nickvergessen]

No, you can already sort by rate etc. on the album.php
see:
gallery/album.php?album_id=1

[grotevoet]

Finally, after several weeks of tweaking, I migrated my forum from phpBB2 to phpB3 in the last 3 days of 2008.

Last night I found that I had the Gallery installed double; very likely because my provider has ModSecurity installed on my host. ModSecurity is an open source web application firewall that runs as an Apache module, and it was blocking part of the web-based convertion of my Smartor album. When the install gets to the step

Code: Select all

install.php/index.php?mode=convert&convert_prefix=phpbb_&sub=create_table

the firewall will block the request with a HTTP 403 error.

I asked my provider to disable the specific line in the firewall, and after they did so, I could complete the convert, but that meant running the install, or at least the convertion, for a second time.

But somehow part of the installation was done double. As other's have seen, you can get the Gallery MOD twice in your ACP.
I had already disabled the second ACP Module through ACP > System > ACP > .Mods (as was the solution posted in this forum), but then I found that in the user profiles Gallery shows up twice, as well.

The errors and issues in one image:

(site is in Dutch, but images should be clear)

After checking how these views are build (they use the function list_modules from INCLUDE/FUNCTIONS_MODULE.PHP) I found the issue to be duplicate entries in the PHPBB_MODULES table in the database. I removed the duplicate entries (PHPBB_GALLERY, ACP_GALLERY_*, ACP_IMPORT_ALBUMS, and UCP_GALLERY_*) with the highest ID's, and that seems to have done the trick.

Maybe it is a good idea to:

• Add the ModSecurity issue to an install FAQ
• On the next version, have the installer do some checks to see if the GALLERY modules exist in the database, already, and offer to remove/use/create duplicates.

Also, with the issue of the lytebox not working sometimes, I noticed that in the ProSilver style you import the galler_lytebox.css, and that has references to {T_THEME_PATH}. For SubSilver2, you include all necessary codes in stylesheet.css. I tried using the import for SubSilver2, as well, and that works fine.

Marc