Development after Release of v0.4.1

[William ArmsTronG]

done

[teo]

Btw
the first step of my cleanup was made.
I ordered all the language-variables alphabetically:

imho very bad decision. Variables should be ordered logically, not alphabetically. Alphabetically order is very bad for translators. I'm Mozilla's product experienced translator to Polish language. I'm Aviary.pl (official Mozilla products Polish translation team) member. Some years ago Mozilla developed special application for localization her products. This application ordered entities alphabetically. Now any translator don't want use this application. Once again - variables should be ordered logically.

[nickvergessen]

they mostly are sorted logically and alphabetically as I try to make the name logical.
the alphabetic sort-order was chosen because of the phpbb-own way.

[jage]

Is thread the right place to make bug reports? I had some code issues when migrating, which could easily come up in restoring a site, or through other human error. Not sure they are "bugs" per se... anyway, where is the appropriate place to post the issues? (They've been resolved and are minor changes)

[nickvergessen]

You may just post it

[jage]

In the MOD notes there is a funny tick (`) after Handymman- when moving the DB (or restoring a backup) this got changed to special characters which (I think) broke the tabbing in ACP creating two PHPBB GALLERY entries with different info instead of the .MOD and AUTOMOD tabs which weren't present. Here's the DB compare where I found the issue:


Second my referer list got a space introduced- " sportsmobileforum.com". I'm not sure if this was me fat fingering it, but my images where broken on the dev and production verson of sportsmobileforum.com and this visually unobvious mistake didn't show up until I got around to tracking down the specific "You are not authorised" error. Instead of taking out the space, here is my fix- there is probably a cleaner way to do this:

in gallery/image.php:

Find:

Code: Select all

   if (!in_array($check_referer, $good_referers))

BEFORE Add:

Code: Select all

   $gr_count = 0;
   foreach ($good_referers as $gr) { $good_referers[$gr_count] = trim($good_referers[$gr_count]); $gr_count++; }

Find (Again:)

Code: Select all

   if (!in_array($check_referer, $good_referers))

REPLACE with:

Code: Select all

   if (!in_array(trim($check_referer), $good_referers))

Also since image.php is actually used to render the images on the gallery list and gallery pages, and in lytebox, instead of getting any error I got only red 'x' broken images, and in lytebox a never loading progress circle... this led me after a lot of Red Herrings because the only time the error message that actually meant something like "bad referer" came up is when trying to open the image directly.

At least within the forum I would like to see a bad referer (instead of not authorised) message, and see it more places a small issue like this affects.

Hope this helps- Thank you for all your hard work... my users have been clammoring for their galleries back ever since I move to phpbb3 last month, and I will finally be able to provide them with them again.

Cheers!

[nickvergessen]

the first one seems to be a bug to AutoMOD.

the second thing, I changed the description to make it more clearly 2 weeks ago:
http://code.bantux.org/repositories/dif ... hp?rev=932

for the errors, I'm still thinking whether we should introduce fail-images

[zkaraca]

Hi Nick,

I just want to ask when the next version will be released? I ask this because there are some fixes in SVN which i don't want to do now because i want to update all files at once. Do you have any idea? Will it be soon or will it take some time?

[nickvergessen]

I think it will need another 2-4weeks

[jage]

In the bbcode table the bbcode entries for bbcode_tpl and second_pass_replace are hard coded to the server:

Code: Select all

<a rel="lytebox" class="image-resize" href="http://127.0.0.1/gallery/image.php?image_id={NUMBER}"><img src="http://127.0.0.1/gallery/image.php?mode=thumbnail&image_id={NUMBER}" alt="{NUMBER}" /></a><br /><a href="http://127.0.0.1/gallery/image_page.php?image_id={NUMBER}">{NUMBER}</a>


Makes development on separate servers an issue, as well as moving phpbb3 to a new directory.

Thanks!