Errors on install script (fixed)

[GoBieN]

Hey,

I'm having some trouble installing the album 3.0.1 on a phpbb-seo premod forum.
Because the module-id's are not in the same order like phpBB original, in your install script you rely on the fact that the modules have the eaxct id like you have.

I have read that you fixed this in 3.0.2 if so, can i download the fixed versio from SVN ?
And if yes, how can i do this ?

[nickvergessen]

we are not on 3.0 but 0.3

you should not use the current 0.3.1dev which may become 0.3.2 because we changed the permission system, so we have to test it at first.

[GoBieN]

Okay, then i guess i have to wait a bit. Or change the install script myself

[nickvergessen]

try this one

[GoBieN]

try this one

Still ahs the module-id hardocded in it (163) and mine is 168.
I adjusting the script like this:

Code: Select all

         //look up module id for UCP_MAIN to use for parent_id in new gallery module
         $sqls = 'SELECT module_id FROM phpbb_modules WHERE module_langname = \'UCP_MAIN\'';
         $results = $db->sql_query($sqls);
         while( $row = $db->sql_fetchrow($results) )
         {
            $gallery_ucp_id = $row['module_id'];
         }         
         if (!isset($gallery_ucp_id )) die ('Could not get UCP_MAIN module ID');
         //look up module id for ACP_CAT_DOT_MODS to use for parent_id in new gallery module
         $sqls = 'SELECT module_id FROM phpbb_modules WHERE module_langname = \'ACP_CAT_DOT_MODS\'';
         $results = $db->sql_query($sqls);
         while( $row = $db->sql_fetchrow($results) )
         {
            $gallery_acpmods_id = $row['module_id'];
         }               
         if (!isset($gallery_acpmods_id )) die ('Could not get ACP_CAT_DOT_MODS module ID');   


Testing now. Will let you know

edit: syntax error in code, fixed

[GoBieN]

Hmm your suggested install script checks for tables before i make selection ?
install.php (did not select mode yet)

SQL ERROR [ mysqli ]
Table 'honda_test.phpbb_gallery_config' doesn't exist [1146]
SQL
SELECT * FROM phpbb_gallery_config
BACKTRACE
FILE: includes/db/mysqli.php
LINE: 143
CALL: dbal->sql_error()

FILE: install_gallery/install.php
LINE: 36
CALL: dbal_mysqli->sql_query()

I commented the lines at line nr 36 where you try to fecth info from the gallery table !

[GoBieN]

SQL ERROR [ mysqli ]
Column 'parent_id' cannot be null [1048]
SQL
INSERT INTO phpbb_modules (module_basename, module_enabled, module_display, parent_id, module_class, module_langname, module_mode, module_auth, left_id, right_id) VALUES ('gallery', 1, 1, NULL, 'acp', 'ACP_GALLERY_OVERVIEW', 'overview', '', 281, 282)
BACKTRACE
FILE: includes/db/mysqli.php
LINE: 143
CALL: dbal->sql_error()
FILE: includes/acp/acp_modules.php
LINE: 804
CALL: dbal_mysqli->sql_query()
FILE: install_gallery/install.php
LINE: 66
CALL: acp_modules->update_module_data()
FILE: install_gallery/install.php
LINE: 336
CALL: add_module()

Fixed by checking ID for newly created module gallery overview for use in next modules

Code: Select all

         //look up module id for  newly created gallery module to use for parent_id in next modules
         $sqls = 'SELECT module_id FROM phpbb_modules WHERE module_langname = \'PHPBB_GALLERY\'';
         $results = $db->sql_query($sqls);
         while( $row = $db->sql_fetchrow($results) )
         {
            $acp_gallery['module_id'] = $row['module_id'];
         }               
         if (!isset($acp_gallery['module_id'])) die ('Could not get $acp_gallery[\'module_id\']');

It was tough, but worth it

Informatie

Installation of the MOD v0.3.1 was successful.
Now delete the install_gallery/ root.

[GoBieN]

Here is the modified install script, feel free to do with it what you want.
http://www.honda-camino.be/root/install_gallery.zip

[nickvergessen]

Hmm your suggested install script checks for tables before i make selection ?
install.php (did not select mode yet)

SQL ERROR [ mysqli ]
Table 'honda_test.phpbb_gallery_config' doesn't exist [1146]
SQL
SELECT * FROM phpbb_gallery_config
BACKTRACE
FILE: includes/db/mysqli.php
LINE: 143
CALL: dbal->sql_error()

FILE: install_gallery/install.php
LINE: 36
CALL: dbal_mysqli->sql_query()

I commented the lines at line nr 36 where you try to fecth info from the gallery table !

ok, thanks will be fixed

[GoBieN]

i'm glad i have the gallery back !

If anyone is thinking about mixing phpBB Gallery with phpBB-SEO then know you will have to change quite a bit for it to work. Seo does not like the fact that gallery is index.php

Instructions here:
http://www.phpbb-seo.com/boards/advance ... html#16325

Demo here:
http://www.honda-camino.be/premod/gallery/gallery.php
http://www.honda-camino.be/premod/your- ... b3-t1.html