phpBB Gallery - Bug tracker

Subscribed email notification - Unsubscribe link is broken (fix completed in git)


The "Unsubscribe image" link in the email notification does not work, missing .hash= and the generate_link_hash seems to produce a differing hash needed to unsubscribe from the image
Last edited by sophos9 on Mon Dec 12, 2011 11:55 pm, edited 1 time in total.


Posted by nickvergessen » Tue Dec 13, 2011 12:31 am

Well we can not append the hash, as it is unique for each user and his current session.
As long as the user does not get an error, I would consider it okay.

Or what happens if a user clicks on such a link?

Posted by sophos9 » Tue Dec 13, 2011 12:38 am

But the code in notification.php generates a hash and appends it directly onto the end of the image_id which is incorrect as it creates a badly formed URL

Example from notification.php
Code: Select all

It should be
Code: Select all

For reference, phpBB uses this to unsubscribe from topic
Code: Select all

Posted by nickvergessen » Mon Feb 27, 2012 11:47 pm

I removed the direct unsubscribe-links for now, as they where not working anyway.

Ticket details