The "Unsubscribe image" link in the email notification does not work, missing .hash= and the generate_link_hash seems to produce a differing hash needed to unsubscribe from the image

Well we can not append the hash, as it is unique for each user and his current session.
As long as the user does not get an error, I would consider it okay.

Or what happens if a user clicks on such a link?

But the code in notification.php generates a hash and appends it directly onto the end of the image_id which is incorrect as it creates a badly formed URL

Example from notification.php

Code: Select all

http://www.talkurbex.com/forum/gallery/image_page.php?mode=unwatch&album_id=8&image_id=3311108eaca

It should be

Code: Select all

http://www.talkurbex.com/forum/gallery/image_page.php?mode=unwatch&album_id=8&image_id=331&hash=ef573d40

For reference, phpBB uses this to unsubscribe from topic

Code: Select all

http://www.talkurbex.com/forum/viewtopic.php?uid=2&f=48&t=6737&unwatch=topic

I removed the direct unsubscribe-links for now, as they where not working anyway.